Move transform

midday-ai · Mar 4, 2024 · 8afc4ab · 8afc4ab
1 parent 3e9c8a6
commit 8afc4ab
Show file tree

Hide file tree

Showing 4 changed files with 113 additions and 111 deletions.
diff --git a/packages/gocardless/src/index.ts b/packages/gocardless/src/index.ts
@@ -1,7 +1,6 @@
 "use server";
 
 import { client } from "@midday/kv";
-import { capitalCase } from "change-case";
 
 const baseUrl = "https://bankaccountdata.gocardless.com";
 
@@ -278,111 +277,3 @@ export async function deleteRequisition(id: string) {
 
   return result.json();
 }
-
-export const mapTransactionMethod = (method: string) => {
-  switch (method) {
-    case "Payment":
-    case "Bankgiro payment":
-    case "Incoming foreign payment":
-      return "payment";
-    case "Card purchase":
-    case "Card foreign purchase":
-      return "card_purchase";
-    case "Card ATM":
-      return "card_atm";
-    case "Transfer":
-      return "transfer";
-    default:
-      return "other";
-  }
-};
-
-const transformName = (transaction) => {
-  if (transaction?.additionalInformation) {
-    return capitalCase(transaction.additionalInformation);
-  }
-
-  if (transaction?.remittanceInformationStructured) {
-    return capitalCase(transaction.remittanceInformationStructured);
-  }
-
-  if (transaction?.remittanceInformationUnstructured) {
-    return capitalCase(transaction.remittanceInformationUnstructured);
-  }
-
-  if (transaction?.creditorName) {
-    return capitalCase(transaction.creditorName);
-  }
-
-  if (transaction?.debtorName) {
-    return capitalCase(transaction?.debtorName);
-  }
-
-  if (transaction?.remittanceInformationUnstructuredArray?.at(0)) {
-    return capitalCase(
-      transaction.remittanceInformationUnstructuredArray?.at(0)
-    );
-  }
-
-  console.log("No transaction name", transaction);
-};
-
-const transformDescription = (transaction, name) => {
-  if (transaction?.remittanceInformationUnstructuredArray?.length) {
-    const text = transaction?.remittanceInformationUnstructuredArray.join(" ");
-    const description = capitalCase(text);
-
-    // NOTE: Sometimes the description is the same as name
-    // Let's skip that and just save if they are not the same
-    if (description !== name) {
-      return description;
-    }
-  }
-};
-
-export const transformTransactions = (transactions, { teamId, accountId }) => {
-  // We want to insert transactions in reversed order so the incremental id in supabase is correct
-  return transactions?.reverse().map((transaction) => {
-    const method = mapTransactionMethod(
-      transaction.proprietaryBankTransactionCode
-    );
-
-    let currencyExchange: { rate: number; currency: string } | undefined;
-
-    if (Array.isArray(transaction.currencyExchange)) {
-      const rate = Number.parseFloat(
-        transaction.currencyExchange.at(0)?.exchangeRate ?? ""
-      );
-
-      if (rate) {
-        const currency = transaction.currencyExchange.at(0)?.sourceCurrency;
-
-        if (currency) {
-          currencyExchange = {
-            rate,
-            currency,
-          };
-        }
-      }
-    }
-
-    const name = transformName(transaction);
-
-    return {
-      date: transaction.valueDate,
-      name,
-      method: method || "unknown",
-      internal_id: `${teamId}_${transaction.internalTransactionId}`,
-      amount: transaction.transactionAmount.amount,
-      currency: transaction.transactionAmount.currency,
-      bank_account_id: accountId,
-      category: transaction.transactionAmount.amount > 0 ? "income" : null,
-      team_id: teamId,
-      currency_rate: currencyExchange?.rate,
-      currency_source: currencyExchange?.currency,
-      balance: transaction?.balanceAfterTransaction?.balanceAmount?.amount,
-      description: transformDescription(transaction, name),
-      status: "posted",
-    };
-  });
-};
diff --git a/packages/gocardless/src/transform.ts b/packages/gocardless/src/transform.ts
@@ -0,0 +1,109 @@
+import { capitalCase } from "change-case";
+
+export const mapTransactionMethod = (method: string) => {
+  switch (method) {
+    case "Payment":
+    case "Bankgiro payment":
+    case "Incoming foreign payment":
+      return "payment";
+    case "Card purchase":
+    case "Card foreign purchase":
+      return "card_purchase";
+    case "Card ATM":
+      return "card_atm";
+    case "Transfer":
+      return "transfer";
+    default:
+      return "other";
+  }
+};
+
+const transformName = (transaction) => {
+  if (transaction?.additionalInformation) {
+    return capitalCase(transaction.additionalInformation);
+  }
+
+  if (transaction?.remittanceInformationStructured) {
+    return capitalCase(transaction.remittanceInformationStructured);
+  }
+
+  if (transaction?.remittanceInformationUnstructured) {
+    return capitalCase(transaction.remittanceInformationUnstructured);
+  }
+
+  if (transaction?.creditorName) {
+    return capitalCase(transaction.creditorName);
+  }
+
+  if (transaction?.debtorName) {
+    return capitalCase(transaction?.debtorName);
+  }
+
+  if (transaction?.remittanceInformationUnstructuredArray?.at(0)) {
+    return capitalCase(
+      transaction.remittanceInformationUnstructuredArray?.at(0)
+    );
+  }
+
+  console.log("No transaction name", transaction);
+};
+
+const transformDescription = (transaction, name) => {
+  if (transaction?.remittanceInformationUnstructuredArray?.length) {
+    const text = transaction?.remittanceInformationUnstructuredArray.join(" ");
+    const description = capitalCase(text);
+
+    // NOTE: Sometimes the description is the same as name
+    // Let's skip that and just save if they are not the same
+    if (description !== name) {
+      return description;
+    }
+  }
+};
+
+export const transformTransactions = (transactions, { teamId, accountId }) => {
+  // We want to insert transactions in reversed order so the incremental id in supabase is correct
+  return transactions?.reverse().map((transaction) => {
+    const method = mapTransactionMethod(
+      transaction.proprietaryBankTransactionCode
+    );
+
+    let currencyExchange: { rate: number; currency: string } | undefined;
+
+    if (Array.isArray(transaction.currencyExchange)) {
+      const rate = Number.parseFloat(
+        transaction.currencyExchange.at(0)?.exchangeRate ?? ""
+      );
+
+      if (rate) {
+        const currency = transaction.currencyExchange.at(0)?.sourceCurrency;
+
+        if (currency) {
+          currencyExchange = {
+            rate,
+            currency,
+          };
+        }
+      }
+    }
+
+    const name = transformName(transaction);
+
+    return {
+      date: transaction.valueDate,
+      name,
+      method: method || "unknown",
+      internal_id: `${teamId}_${transaction.internalTransactionId}`,
+      amount: transaction.transactionAmount.amount,
+      currency: transaction.transactionAmount.currency,
+      bank_account_id: accountId,
+      category: transaction.transactionAmount.amount > 0 ? "income" : null,
+      team_id: teamId,
+      currency_rate: currencyExchange?.rate,
+      currency_source: currencyExchange?.currency,
+      balance: transaction?.balanceAfterTransaction?.balanceAmount?.amount,
+      description: transformDescription(transaction, name),
+      status: "posted",
+    };
+  });
+};
diff --git a/packages/jobs/src/transactions/setup.ts b/packages/jobs/src/transactions/setup.ts
@@ -1,5 +1,6 @@
 import { processPromisesBatch } from "@/utils/process";
-import { getTransactions, transformTransactions } from "@midday/gocardless";
+import { getTransactions } from "@midday/gocardless";
+import { transformTransactions } from "@midday/gocardless/src/transform";
 import { eventTrigger } from "@trigger.dev/sdk";
 import { revalidateTag } from "next/cache";
 import { z } from "zod";

diff --git a/packages/jobs/src/transactions/sync.ts b/packages/jobs/src/transactions/sync.ts
@@ -1,4 +1,5 @@
-import { getTransactions, transformTransactions } from "@midday/gocardless";
+import { getTransactions } from "@midday/gocardless";
+import { transformTransactions } from "@midday/gocardless/src/transform";
 import { formatISO, subMonths } from "date-fns";
 import { revalidateTag } from "next/cache";
 import { client, supabase } from "../client";