At least one account succedded status

midday-ai · Oct 15, 2024 · d9b331e · d9b331e
1 parent b9b52a1
commit d9b331e
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 35 deletions.
diff --git a/packages/jobs/src/transactions/manual-sync.ts b/packages/jobs/src/transactions/manual-sync.ts
@@ -174,21 +174,18 @@ client.defineJob({
         await io.logger.error("Some accounts failed to sync", failedAccounts);
 
         // Update failed accounts
-        // for (const failedAccount of failedAccounts) {
-        //   await supabase
-        //     .from("bank_accounts")
-        //     .update({
-        //       // enabled: false, // TODO: Disable if the account id is not found in the bank connection
-        //       // error_details: failedAccount.error instanceof Error
-        //       //   ? failedAccount.error.message
-        //       //   : String(failedAccount.error),
-        //     })
-        //     .eq("id", failedAccount.accountId);
-
-        //   await io.logger.info("Disabled failed account", {
-        //     accountId: failedAccount.accountId,
-        //   });
-        // }
+        for (const failedAccount of failedAccounts) {
+          await supabase
+            .from("bank_accounts")
+            .update({
+              // enabled: false, // TODO: Disable if the account id is not found in the bank connection
+              error_details:
+                failedAccount.error instanceof Error
+                  ? failedAccount.error.message
+                  : String(failedAccount.error),
+            })
+            .eq("id", failedAccount.accountId);
+        }
       }
 
       // Update bank connection status based on sync results

diff --git a/packages/jobs/src/transactions/sync.ts b/packages/jobs/src/transactions/sync.ts
@@ -103,6 +103,7 @@ client.defineJob({
         connectionMap.set(account.bank_connection.id, {
           success: true,
           errorRetries: 0,
+          status: "connected",
         });
 
         return {
@@ -113,30 +114,31 @@ client.defineJob({
       } catch (error) {
         // Handle errors and update connection status
         let errorDetails = "Unknown error occurred";
+        let errorCode = "unknown";
 
         if (error instanceof Midday.APIError) {
           const parsedError = parseAPIError(error);
           errorDetails = parsedError.message;
+          errorCode = parsedError.code;
         } else if (error instanceof Error) {
           errorDetails = error.message;
         }
 
         await io.logger.error(`Error processing account ${account.id}`, {
           error: errorDetails,
+          errorCode,
         });
 
-        const connectionStatus = connectionMap.get(account.bank_connection.id);
-        if (!connectionStatus) {
-          connectionMap.set(account.bank_connection.id, {
-            success: false,
-            errorRetries: account.bank_connection.error_retries + 1,
-          });
-        }
+        connectionMap.set(account.bank_connection.id, {
+          success: false,
+          status: errorCode,
+        });
 
         return {
           success: false,
           accountId: account.id,
           error: errorDetails,
+          errorCode,
         };
       }
     });
@@ -156,23 +158,23 @@ client.defineJob({
           await io.logger.error("Some accounts failed to sync", failedResults);
 
           // Update failed accounts
-          // for (const failedResult of failedResults) {
-          //   await supabase
-          //     .from("bank_accounts")
-          //     .update({
-          //       // enabled: false, // TODO: Disable if the account id is not found in the bank connection
-          //       // error_details: failedResult.error,
-          //     })
-          //     .eq("id", failedResult.accountId);
-          // }
+          for (const failedResult of failedResults) {
+            await supabase
+              .from("bank_accounts")
+              .update({
+                // enabled: false, // TODO: Disable if the account id is not found in the bank connection
+                error_details: failedResult.error,
+              })
+              .eq("id", failedResult.accountId);
+          }
         }
 
         // Update bank connections status
-        for (const [connectionId] of connectionMap) {
+        for (const [connectionId, connectionStatus] of connectionMap) {
           let updateData: {
             last_accessed?: string;
             status: string;
-            error_details?: null;
+            error_details?: string | null;
             error_retries?: number;
           };
 
@@ -196,10 +198,11 @@ client.defineJob({
             const newErrorRetries = currentErrorRetries + 1;
 
             updateData = {
-              status: newErrorRetries >= 3 ? "disconnected" : "unknown",
+              status: connectionStatus.status,
+              error_details: connectionStatus.errorDetails,
             };
 
-            if (updateData.status === "disconnected") {
+            if (connectionStatus.status !== "unknown") {
               updateData.error_retries = newErrorRetries;
             }
           }