Merge pull request #1281 from iiroj/fix-earlyresponse-type

fix: make request.earlyResponse an optional field in TypeScript type definitions
middyjs · Feb 27, 2025 · 82ba616 · 82ba616
2 parents 7641859 + 2bcdfd1
commit 82ba616
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/core/index.d.ts b/packages/core/index.d.ts
@@ -30,7 +30,7 @@ export interface Request<
   event: TEvent
   context: TContext
   response: TResult | null
-  earlyResponse: TResult | null
+  earlyResponse?: TResult | null | undefined
   error: TErr | null
   internal: TInternal
 }

diff --git a/packages/core/index.test-d.ts b/packages/core/index.test-d.ts
@@ -539,12 +539,15 @@ expectType<middy.MiddyfiedHandler<APIGatewayProxyEvent, number>>(
 )
 
 // Issue #1275 Early Response type
-middy()
+middy<unknown, string>()
   .before(async (request) => {
     request.earlyResponse = 'Hello, world!'
   })
   .use({
     after: (request) => {
-      request.earlyResponse = 'Hello, world!'
+      request.earlyResponse = null
     }
   })
+  .onError(async (request) => {
+    request.earlyResponse = undefined
+  })
diff --git a/packages/util/index.test-d.ts b/packages/util/index.test-d.ts
@@ -89,7 +89,6 @@ TInternal
     succeed: () => {}
   },
   response: null,
-  earlyResponse: null,
   error: null,
   internal: {
     boolean: true,