-
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(a1): attribute with wrong default (#55)
Here it saves the string value instead of the index. The index is used only inside the message: ``` elif status == DeviceAttributes.fan_speed: if value in MideaA1Device._speeds.keys(): self._attributes[status] = MideaA1Device._speeds.get(value) else: self._attributes[status] = None ``` That's why fan_speed should be a string <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected the `fan_speed` attribute to display string values instead of integers. - **New Features** - Enhanced type safety with added type annotations in various methods and attributes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Simone Chemelli <simone.chemelli@gmail.com>
- Loading branch information
1 parent
739b1bc
commit 7e66870
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters