Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pre-commit tweak #18

Merged
merged 4 commits into from
May 25, 2024

Conversation

chemelli74
Copy link
Member

@chemelli74 chemelli74 commented May 25, 2024

Tweak pre-commit to work with current code base:

  • remove poetry, not used in this project
  • temporary commented prettier and mypy
  • updated codespell to handle "ignore" for specific words

EDIT:

You can test all hooks for all files with git ls-files | xargs pre-commit run --files

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 0.09%. Comparing base (158eb51) to head (6a4db30).

Files Patch % Lines
midealocal/device.py 0.00% 5 Missing ⚠️
midealocal/discover.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #18   +/-   ##
=====================================
  Coverage   0.09%   0.09%           
=====================================
  Files         77      77           
  Lines       6561    6561           
=====================================
  Hits           6       6           
  Misses      6555    6555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokam rokam merged commit a2db14a into midea-lan:main May 25, 2024
3 checks passed
@chemelli74 chemelli74 deleted the chemelli74-pre-commit-part-1 branch May 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants