fix: message protocol version default #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (6)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
rokam
approved these changes
Oct 4, 2024
rokam
previously requested changes
Oct 4, 2024
Sorry I lost this part, can you be more detailed ? |
Look that CI is failing. |
|
The protocol compare sound like a wrong logic now that we know we are speaking about message and not device. |
See #320 |
rokam
approved these changes
Oct 5, 2024
It was auto merged with the error We need to fix it |
chemelli74
pushed a commit
that referenced
this pull request
Oct 6, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.1](v6.0.0...v6.0.1) (2024-10-06) ### Bug Fixes * add missing body_type "163" ([#317](#317)) ([45f7bd2](45f7bd2)) * message protocol version default ([#316](#316)) ([2f4e5d1](2f4e5d1)) * protocol check in B6 devices ([#320](#320)) ([55659c1](55659c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.