Fix console styles + Escape HTML safely #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Agrega la función escapeHtml para evitar inyecciones de HTML en strings. - Simplifica el renderizado con innerHTML. - Simplifica la lógica en createListItem y handlers.default. - Aplica estilos correctamente a tipos primitivos, objetos y arrays. - Muestra claves no válidas como strings escapadas con comillas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problema
El PR #267 solucionó el riesgo de XSS en la consola, pero rompió el formato visual de objetos y arrays, ya que innerHTML era necesario para aplicar las clases de estilos correspondientes. (Hay un issue al respecto #273)
Este código simplifica la prevención de XSS a la vez que soluciona los bugs de estilos en los diferentes tipos de datos que se pueden mostrar en la consola.
✅ Solución
escapeHtmlpara escapar contenido HTML.📸 Capturas
🧪 Tests
<,>,",',&) no rompen el DOM."some-key"se muestran con comillas y sin romper la estructura.Fixes #273