Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated net.Error.Temporary #1589

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Remove use of deprecated net.Error.Temporary #1589

merged 1 commit into from
Aug 3, 2024

Commits on Aug 3, 2024

  1. Remove use of deprecated net.Error.Temporary

    net.Error.Temporary has been deprecated since Go 1.18. There
    has been some discussion around what to use in server accept loops
    instead [1], but the suggestion seems to be that it may be a mistake
    to have any sort of retries in place [2].
    
    This PR removes it, which may expose some users to errors that were
    previously swallowed and retried, but at the expense of leaking file
    descriptors and the like.
    
    1: https://groups.google.com/g/golang-nuts/c/-JcZzOkyqYI/m/xwaZzjCgAwAJ?pli=1
    2: https://groups.google.com/g/golang-nuts/c/-JcZzOkyqYI/m/vNNiVn_LAwAJ
    johanbrandhorst authored and miekg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    37396bf View commit details
    Browse the repository at this point in the history