Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention when to enable the 'editor' feature #177

Merged

Conversation

rchriste
Copy link
Contributor

I was confused at how to enable the Editor feature, which is to enable
the editor feature. Which is obvious in hindsight. This small doc PR
is meant to help prevent this point of confusion in the future.

I was confused at how to enable the Editor feature, which is to enable
the `editor` feature. Which is obvious in hindsight. This small doc PR
is meant to help prevent this point of confusion in the future.
Copy link
Owner

@mikaelmello mikaelmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, sorry for missing that lol.

Thanks for your PR!

inquire/src/lib.rs Outdated Show resolved Hide resolved
inquire/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rchriste rchriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take @mikaelmello 's suggestion

inquire/src/lib.rs Outdated Show resolved Hide resolved
inquire/src/lib.rs Outdated Show resolved Hide resolved
@mikaelmello
Copy link
Owner

Not sure what the lint is complaining about, but it looks to be about LF to CRLF changes added

@rchriste
Copy link
Contributor Author

rchriste commented Sep 23, 2023

Not sure what the lint is complaining about, but it looks to be about LF to CRLF changes added

The issue was an extra whitespace after the //!

I am new at this :) How are things now? Does this look good?

@mikaelmello mikaelmello enabled auto-merge (squash) November 1, 2023 13:19
@mikaelmello mikaelmello merged commit 1c7ece7 into mikaelmello:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants