Skip to content

Commit

Permalink
Codesigning the dmg file, storing the artifact
Browse files Browse the repository at this point in the history
  • Loading branch information
mikekazakov committed Jan 31, 2024
1 parent 46dcd41 commit 1024e21
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:
run: "sudo xcode-select -s /Applications/Xcode_$XC_VERSION.app"
- name: Install deps
run: brew install create-dmg
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install the Apple certificate and provisioning profile
env:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
Expand Down Expand Up @@ -52,4 +54,9 @@ jobs:
run: |
security delete-keychain $RUNNER_TEMP/app-signing.keychain-db
rm ~/Library/MobileDevice/Provisioning\ Profiles/build_pp.provisionprofile
- uses: actions/upload-artifact@v4
with:
name: nimble-commander-nightly
path: Scripts/*.dmg
if-no-files-found: error

5 changes: 2 additions & 3 deletions Scripts/build_nightly.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,10 @@ APP_DIR=$($XC -showBuildSettings | grep " BUILT_PRODUCTS_DIR =" | sed -e 's/.*=
APP_NAME=$($XC -showBuildSettings | grep " FULL_PRODUCT_NAME =" | sed -e 's/.*= *//' )
APP_PATH=$APP_DIR/$APP_NAME

$XC build
#$XC build | xcpretty
$XC build | xcpretty

cp -R "${APP_PATH}" ./


# Sign the app with timestamps
codesign \
--verbose \
Expand Down Expand Up @@ -91,6 +89,7 @@ create-dmg \
--icon-size 128 \
--icon "${APP_NAME}" 176 192 \
--app-drop-link 432 192 \
--codesign "Developer ID Application: Mikhail Kazakov (AC5SJT236H)" \
"${DMG_NAME}" \
"${APP_NAME}"

Expand Down

0 comments on commit 1024e21

Please sign in to comment.