Skip to content

Conversation

@Kaustav96
Copy link

@Kaustav96 Kaustav96 commented Oct 18, 2019

Pull Request Overview

The Commands section currently displays some of the available commands. Currently the display of the commands is center justified to show the code and a corresponding description. This display and formatting could be presented in a much nicer layout.

Issue Reference

Closes #2

Open Questions or Items to Callout

PR Checklist

  • Assign PR to yourself

@mikelax
Copy link
Owner

mikelax commented Oct 29, 2019

Thanks @Kaustav96 for the PR. I just took a look at the changes and the page HTML and I think there is an even easier way to do this. I like how you made the sections that contain the list of commands justify text. Instead of applying this css rule for all .major classes, let's instead apply the rule for a new class we add called .commands.
Then on lines 125 and 146, you can update to include this new class.

.major h3 {
font-size: 52px;
}
.major {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.major {
.commands {

delete the two blocks above this for .major h2 and .major h3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Formatting & Layout of Commands section

2 participants