Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restore basic unit tests #271

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: Restore basic unit tests #271

merged 1 commit into from
Jan 23, 2025

Conversation

milesburton
Copy link
Owner

fix:

Mocked the ESP8266 core libraries to ensure that basic unit tests pass successfully.
Excluded the recent ESP-WebServer example from the testing suite.

Note: This update does not require a new release.

@milesburton
Copy link
Owner Author

@RobTillaart This has been a total pain but we have some basic tests running. I'll merge this (assuming it passes) and attempt to re-enable your suite.

@milesburton milesburton marked this pull request as ready for review January 23, 2025 19:19
DimitarChristoff
DimitarChristoff reviewed Jan 23, 2025
View reviewed changes
Copy link

@DimitarChristoff DimitarChristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@milesburton milesburton merged commit eb995ea into master Jan 23, 2025
5 checks passed
@milesburton milesburton deleted the fix/restore-unit-tests branch January 23, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitarChristoff DimitarChristoff DimitarChristoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milesburton @DimitarChristoff