Skip to content

Do not use SDP munging to setup Simulcast, rely on the new APIs #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dubeyShivank wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Do not use SDP munging to setup Simulcast, rely on the new APIs #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
119bf4c
Do not use SDP munging to setup Simulcast, rely on the new APIs
dubeyShivank Aug 13, 2025
4551640
Cleanup
dubeyShivank Aug 13, 2025
38d110f
Fix build
dubeyShivank Aug 13, 2025
6acde81
Remove SDP simulcast unit tests
dubeyShivank Aug 13, 2025
60fba8c
Partial migration from munging to APIs. DTX and abs-capture-timestamp…
dubeyShivank Aug 18, 2025
ac27f16
Fix dtx setting
dubeyShivank Sep 8, 2025
b5b6c6f
update dir path to logger
dubeyShivank Sep 8, 2025
647e9ee
remove SDK parser from docs
dubeyShivank Sep 8, 2025
7850b7d
add a utility function for testing
dubeyShivank Sep 8, 2025
fc3b8c4
Fix type definition file
dubeyShivank Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-humans-explain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@millicast/sdk": minor
---

Migrated simulcast setup to use the new sendEncodings API instead of SDP munging.
6 changes: 1 addition & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ classDiagram
+stopStats()
+async getRTCLocalSDP(options) string
+async setRTCRemoteSDP(sdp)
+updateBandwidthRestriction(sdp, bitrate) string
+updateBandwidthRestriction(bitrate) string
+async updateBitrate(bitrate)
}
class Signaling {
Expand Down Expand Up @@ -199,10 +199,6 @@ classDiagram
}
class SdpParser {
<<Singleton>>
+setStereo(sdp) string
+setDTX(sdp) string
+setVideoBitrate(sdp, bitrate) string
+setSimulcast(sdp, codec) string
}
class Logger {
<<Singleton>>
Expand Down
Loading
Loading