Conversation
gregdolby
requested review from
Santiago-Souto,
juanpiquerez,
turbidwater and
vincentsong
and removed request for
turbidwater
turbidwater
approved these changes
Sep 9, 2024
Contributor
Author
|
This PR is a hack because the player calls director and subscribe twice. The other option would be adding a side effect to the tokenGen callback and that route might also be to late in getting DRM info on subscriber response. The player needs to know if it's a DRM stream before it initializes the app because it needs to use a separate audio element for DRM streams. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove query param entirely. We determine if the stream is DRM from the Director.getSubscriber() response. I am not sure if this will ever be merged in but it seems people are starting to push for this.