refactory of birdwatch #208
Conversation
yiwangdr
commented
Oct 17, 2023
yiwangdr
commented
- add an interface layer to decouple infra from features
- add tikv support
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
| // RemoveWithPrefix removes the keys for the given prefix. | ||
| func (kv *txnTiKV) RemoveWithPrefix(ctx context.Context, prefix string) error { | ||
| prefix = path.Join(kv.rootPath, prefix) | ||
| ctx, cancel := context.WithTimeout(ctx, RequestTimeout) |
There was a problem hiding this comment.
NIT: RequestTimeout shall be deprecated since ctx could be controlled from command
| return apps, nil | ||
| } | ||
|
|
||
| func (kv *txnTiKV) BackupKV(base, prefix string, w *bufio.Writer, ignoreRevision bool, batchSize int64) error { |
There was a problem hiding this comment.
NIT: maybe a better abstraction here is to implement an iterator for EtcdKV and tikv
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, yiwangdr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind feature |
|
@congqixia: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
