Skip to content

Commit

Permalink
fix(dependencies): fix breaking change in FlagEmbedding 1.3 dependency (
Browse files Browse the repository at this point in the history
#44)

## Description

FlagEmbedding v1.3.X has breaking change with pymilvus/milvus-model : 

```
Error occurred: M3Embedder.encode() missing 1 required positional argument: 'queries'
```

This is a hotfix to force a version 1.2.X.

I think it's quite urgent since it can break multiple production system
with lazy dependency loader.
  • Loading branch information
rguilmont authored Nov 6, 2024
1 parent 7715504 commit 0e05e5e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion milvus_model/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def import_sentence_transformers():

def import_FlagEmbedding():
_check_library("peft", package="peft")
_check_library("FlagEmbedding", package="FlagEmbedding>=1.2.2")
_check_library("FlagEmbedding", package="FlagEmbedding~=1.2.11")

def import_nltk():
_check_library("nltk", package="nltk>=3.9.1")
Expand Down

0 comments on commit 0e05e5e

Please sign in to comment.