Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array fields support #81

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Conversation

BlackGad
Copy link
Contributor

@BlackGad BlackGad commented Apr 19, 2024

This PR introduces support for Array fields, encompassing schema definitions as well as data requests, inserts, and upserts.

I have authored a series of unit tests to cover various array types.

Additionally, the Proto submodule has been upgraded to v2.4.

Fixes #77

@BlackGad BlackGad mentioned this pull request Apr 19, 2024
Copy link
Collaborator

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks pretty good! See review comments mainly for some nits.

BTW can I ask you to submit the 2.4 proto change in a separate PR, as I'm planning on backporting the array support to 2.3 as well?

Milvus.Client/ArrayFieldData.cs Outdated Show resolved Hide resolved
Milvus.Client/ArrayFieldData.cs Outdated Show resolved Hide resolved
Milvus.Client/FieldSchema.cs Outdated Show resolved Hide resolved
Milvus.Client/ArrayFieldData.cs Outdated Show resolved Hide resolved
Milvus.Client/FieldData.cs Outdated Show resolved Hide resolved
Milvus.Client/ArrayFieldData.cs Outdated Show resolved Hide resolved
Milvus.Client/ArrayFieldData.cs Outdated Show resolved Hide resolved
@BlackGad
Copy link
Contributor Author

Proto version change reverted. from this PR Added #82 for this change

@BlackGad BlackGad requested a review from roji April 22, 2024 06:30
@BlackGad
Copy link
Contributor Author

Did not resolve all the conversation here. Can you take a look for modifications?

Copy link
Collaborator

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quality PR @BlackGad!

@roji roji merged commit b1bd801 into milvus-io:main Apr 22, 2024
2 checks passed
roji pushed a commit that referenced this pull request Apr 22, 2024
Fixes #77

(cherry picked from commit b1bd801)
@roji
Copy link
Collaborator

roji commented Apr 22, 2024

Backported to 2.3.0-preview.2 via 6aea142

@BlackGad BlackGad deleted the vshkolka_array_support branch July 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support array fields
2 participants