-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array fields support #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks pretty good! See review comments mainly for some nits.
BTW can I ask you to submit the 2.4 proto change in a separate PR, as I'm planning on backporting the array support to 2.3 as well?
This reverts commit 4f7a753.
Proto version change reverted. from this PR Added #82 for this change |
Did not resolve all the conversation here. Can you take a look for modifications? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quality PR @BlackGad!
Backported to 2.3.0-preview.2 via 6aea142 |
This PR introduces support for Array fields, encompassing schema definitions as well as data requests, inserts, and upserts.
I have authored a series of unit tests to cover various array types.
Additionally, the Proto submodule has been upgraded to v2.4.
Fixes #77