Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search result shouldn't contain the copied 'id' column #406

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

shanghaikid
Copy link
Contributor

No description provided.

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (625e61b) to head (9d878e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   97.33%   97.26%   -0.08%     
==========================================
  Files          43       43              
  Lines        2923     2921       -2     
  Branches      724      723       -1     
==========================================
- Hits         2845     2841       -4     
- Misses         78       79       +1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit 4ff9675 into main Jan 15, 2025
3 of 5 checks passed
shanghaikid added a commit that referenced this pull request Jan 15, 2025
* fix: search result shouldn't contain the copied 'id' column

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

* update

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

---------

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants