-
Notifications
You must be signed in to change notification settings - Fork 42
Creating unique names for new nets #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XRenso
wants to merge
5
commits into
main
Choose a base branch
from
unique-net-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9c8f20d
Generate cosmic type of names for network and unique by timestamp
XRenso 7c3900d
Add additional cosmic object names to the name generation function
XRenso 18023d5
Fix mistake in readme
XRenso a87c75a
Add name base for generator in json file
XRenso 2f268f4
Merge branch 'main' into unique-net-names
i1ya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "cosmic_objects": [ | ||
| "Комета", | ||
| "Звезда", | ||
| "Галактика", | ||
| "Туманность", | ||
| "Спутник", | ||
| "Вселенная", | ||
| "Астероид", | ||
| "Планета", | ||
| "Метеорит", | ||
| "Квазар", | ||
| "Пульсар", | ||
| "Чёрная дыра", | ||
| "Суперновая", | ||
| "Созвездие", | ||
| "Космодром", | ||
| "Телескоп", | ||
| "Ракета", | ||
| "Орбита", | ||
| "Экзопланета", | ||
| "Космический корабль", | ||
| "Межзвёздный объект", | ||
| "Космическая станция", | ||
| "Темная материя", | ||
| "Космический зонд" | ||
| ], | ||
| "prefixes": ["", "XB-", "NGC-", "HD-", "M-", "IC-", "PG-", "PSR-"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут точно лямбда нужна? Нельзя просто
default= generate_cosmic_name, если функцию передавать надо?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, иначе результат функции он кеширует и при создании сети каждый раз будет одно и то же название. Лямбда же позволяет при каждом создании сети вызывать функцию
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так если default= generate_cosmic_name использовать, мы тоже чисто функцию передаём, нет?