Replace deprecated np.mat() with np.asmatrix() #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feirog
added a commit
to feirog/nimfa
that referenced
this pull request
Jan 16, 2026
I noticed several 'np.mat()' instances were still present in the package and limited fix mims-harvard#66 . As such, issue mims-harvard#65 was still present. With this update, I've ensured all instances of 'np.mat()' have been replaced to 'np.asmatrix()'. To do so, I've the following shell command: find * -type f -exec sed -i 's/np.mat(/np.asmatrix(/g' {} \; This should fix several broken functions, hopefully making Nimfa compatible with numpy v.2.0.0+. Resolves issue mims-harvard#65 , building on mims-harvard#66 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all usages of
np.mat(), which now throws errors, withnp.asmatrix()Resolves issue #65, fixing several broken factorization algorithms.