Skip to content

Potential fix for code scanning alert no. 9: Workflow does not contain permissions#7

Merged
mindedal merged 1 commit intomainfrom
Workflow-does-not-contain-permissions
Oct 7, 2025
Merged

Potential fix for code scanning alert no. 9: Workflow does not contain permissions#7
mindedal merged 1 commit intomainfrom
Workflow-does-not-contain-permissions

Conversation

@mindedal
Copy link
Owner

@mindedal mindedal commented Oct 7, 2025

Potential fix for https://github.com/Tyrowin/gochat/security/code-scanning/9

The best way to fix the problem is to add a permissions block at the workflow root (for all jobs), or at the job level for jobs that require permissions deviating from the workflow default. Since the notify job (and likely most jobs in this workflow) do not need write access, set contents: read at the root, which is the strictest reasonable setting. If any job requires additional permissions (such as uploading SARIF results in docker-scan via codeql-action/upload-sarif), set those specific permissions for individual jobs. For now, this fix will add the recommended block at the top level of .github/workflows/ci.yml, which is best practice and addresses the CodeQL alert.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@mindedal mindedal marked this pull request as ready for review October 7, 2025 20:59
@mindedal mindedal merged commit c315de3 into main Oct 7, 2025
12 checks passed
@mindedal mindedal deleted the Workflow-does-not-contain-permissions branch October 7, 2025 20:59
mindedal added a commit that referenced this pull request Oct 29, 2025
Potential fix for code scanning alert no. 9: Workflow does not contain permissions
mindedal added a commit that referenced this pull request Nov 20, 2025
Potential fix for code scanning alert no. 9: Workflow does not contain permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant