Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #203

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Misc fixes #203

merged 2 commits into from
Nov 22, 2023

Conversation

ianardee
Copy link
Contributor

Description

  • 📝 harmonize custom doc sample code
  • 🐛 custom APIs don't support async mode

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee merged commit f5a792d into main Nov 22, 2023
22 checks passed
@ianardee ianardee deleted the misc-fixes branch November 22, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianMindee sebastianMindee sebastianMindee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianardee @sebastianMindee