OHLC charts #89
Merged
OHLC charts #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make configurable zoom level and colors.
add crisp_edges option; make colorized_bars optional; make body border optional.
|
@DaTrader - I have created this PR from your fork. Hopefully this is what you meant about approving a workflow. |
|
@mindok It's formatted now and I also optimized it a bit not to call a potentially expensive function twice. |
|
@mindok Can you please approve this? |
|
Apologies for the delay @DaTrader - merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Features
crispEdgesrendering option (looks way better when SVG container size and SVG size match 1:1)Code housekeeping
ohlc.ex(except for protocol implementation ones)