forked from moai/moai-dev
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5% Day] Rip Stuff Out #137
Open
aab29
wants to merge
29
commits into
mindsnacks-dev
Choose a base branch
from
feature/rip-stuff-out
base: mindsnacks-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `AKUExtLoadLuacurl`. Removed implementation of `AKUExtLoadLuasql` and the symbol `luaopen_luasql_sqlite3`.
… headers. Removed registration for Moai chipmunk integration classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also wouldn't be surprised if this doesn't build on Android yet. We might need to update the CMakeLists or something. 🤖✋
MOAI is filled with lots of 3rd-party libraries and utilities that we aren't using at all. 🕸️ They probably seemed like good things to include in a game engine back in 2011 or so. 🏛️ These days there are better/more reliable ways to get most of this functionality. So I tried ripping out as much as I could. 🗿✂️ This is mostly low-hanging fruit. 🍍 I'm sure we could make more substantial improvements if we kept at it. 🗿🪓
Things I removed:
OpenSSL
library 🚪MOAIHashWriter
✍️USHashWriter
and subclasses 🇺🇸luacrypto
library 📉luasql
library 💿luafilesystem
library 💾AKUExtLoadLuasql
,AKUExtLoadLuacrypto
,AKUExtLoadLuacurl
, andAKUExtLoadLuafilesystem
🗿USXmlReader
class 🕸️expat
XML parsing library 🛥️chipmunk
physics engine (We only use Box2D.) 🐿️