Skip to content

Conversation

@zyd-ustc
Copy link

What does this PR do?

Adds
1.auto mappings for Sam2

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@zyd-ustc zyd-ustc requested a review from vigo999 as a code owner November 14, 2025 02:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zyd-ustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the MindOne framework by integrating the SAM2 model and its associated components into the automatic configuration, image processing, modeling, and general processing modules. This integration allows for seamless recognition and utilization of SAM2-related classes, simplifying development and improving the extensibility of the system for future computer vision tasks.

Highlights

  • SAM2 Configuration Integration: Added automatic configuration mappings for SAM2, including Sam2Config, Sam2HieraDetConfig, and Sam2VisionConfig, enabling the system to recognize and utilize these configurations automatically.
  • SAM2 Image Processor Support: Integrated Sam2ImageProcessorFast into the automatic image processing mappings, allowing for streamlined handling of SAM2-specific image processing tasks.
  • SAM2 Model Auto-Mapping: Included Sam2Model, Sam2HeriaDetModel, and Sam2VisionModel in the automatic model mappings, facilitating the dynamic loading and use of these SAM2 model variants.
  • SAM2 General Processor: Added Sam2Processor to the automatic processor mappings, providing a unified interface for SAM2-related processing operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds auto-mappings for SAM2 models. The changes are generally good, but I've identified a few minor formatting inconsistencies and a potential typo in a model name that should be addressed for correctness and code quality.

zyd-ustc and others added 3 commits November 14, 2025 11:10
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant