Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an exit button #49

Closed
wants to merge 2 commits into from
Closed

Added an exit button #49

wants to merge 2 commits into from

Conversation

Hzqkii
Copy link
Contributor

@Hzqkii Hzqkii commented Jan 7, 2025

Copy link
Member

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert Resources/icon-edit.png
Making the picture executable is not needed.


@devendrn You can decide about this, I'm more towards rejecting this without being disabled by default using launcher settings and a checkbox in the General Page.

The qt6 branch as used in flatpak/AUR is the development branch.

@Hzqkii
Copy link
Contributor Author

Hzqkii commented Jan 7, 2025

I made it, non-executable, not executable.
Edit: oh wait it mustve been a typo

@ChristopherHX
Copy link
Member

Making unrelated changes to pictures could cause a merge conflict with the qt6 branch as well.

I dismissed the requested changes state now

@devendrn
Copy link
Member

devendrn commented Jan 8, 2025

@Hzqkii Open a new PR to the qt6 branch. I will manage the rest including the toggle option to enable this. I may also change the icon, as it does not match the design style of other icons.

I'm closing this PR as I don't want these changes in ng branch.

@devendrn devendrn closed this Jan 8, 2025
@Hzqkii
Copy link
Contributor Author

Hzqkii commented Jan 8, 2025

@Hzqkii Open a new PR to the qt6 branch. I will manage the rest including the toggle option to enable this. I may also change the icon, as it does not match the design style of other icons.

I'm closing this PR as I don't want these changes in ng branch.

#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants