Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume hitter ~= nil in on_punchplayer callback #138

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Don't assume hitter ~= nil in on_punchplayer callback #138

merged 2 commits into from
Mar 17, 2024

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Mar 15, 2024

Should close #137

@Niklp09 Niklp09 added the bug Something isn't working label Mar 15, 2024
@SmallJoker
Copy link
Member

An early return would be nicer to read than deeply nested conditions.

@BuckarooBanzay
Copy link
Member

Nice, thanks 👍

@BuckarooBanzay BuckarooBanzay merged commit 25369e5 into master Mar 17, 2024
4 checks passed
@Niklp09 Niklp09 deleted the allow_hitter_being_nil branch March 17, 2024 10:41
@Niklp09 Niklp09 mentioned this pull request Mar 18, 2024
Merged
mckaygerhard added a commit to minenux/minetest-mod-3d_armor that referenced this pull request Mar 27, 2024
@mckaygerhard
Call custom on_punched functions w/ hitter = nil too
156ab39 
* this allows to propagates the nil on custom mods
* related to minetest-mods#138 (comment)
* backported minetest-mods#141
* improves commit a48a7f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3d_armor assumes puncher ~= nil
4 participants
@Niklp09 @SmallJoker @BuckarooBanzay @appgurueu