Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of recursive call in default.dig_up #3133

Merged
merged 16 commits into from
Sep 8, 2024
Merged

Get rid of recursive call in default.dig_up #3133

merged 16 commits into from
Sep 8, 2024

Conversation

Emojigit
Copy link
Contributor

Fixes #3075

This PR fixes the recursive calling of default.dig_up and adds a parameter for a maximum number of nodes searched.

This PR is ready for review.

sfan5
sfan5 reviewed Jun 17, 2024
View reviewed changes
mods/default/init.lua Outdated Show resolved Hide resolved
sfan5
sfan5 reviewed Jun 17, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
sfan5
sfan5 reviewed Jun 17, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
sfan5
sfan5 reviewed Jun 17, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
@Emojigit Emojigit requested a review from sfan5 June 17, 2024 10:53
@Emojigit
Copy link
Contributor Author

@sfan5 Change applied in 0e79158. Ready for review again.

sfan5
sfan5 reviewed Jun 17, 2024
View reviewed changes
mods/default/init.lua Outdated Show resolved Hide resolved
@Emojigit Emojigit requested a review from sfan5 June 17, 2024 22:32
sfan5
sfan5 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

SmallJoker
SmallJoker reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Tested with print in minetest.dig_up while digging papyrus. Height limit works too.

mods/default/functions.lua Show resolved Hide resolved
mods/default/functions.lua Outdated Show resolved Hide resolved
@Emojigit Emojigit requested a review from SmallJoker June 22, 2024 06:45
Emojigit and others added 2 commits June 25, 2024 18:56
@Emojigit @SmallJoker
[WIP] Move in_deg_up to start and end of function
5ae2b04 
Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>
@Emojigit
Finish handling errors
f19fa6e
@Emojigit Emojigit requested a review from appgurueu June 25, 2024 11:08
sfan5
sfan5 reviewed Jun 26, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
sfan5
sfan5 reviewed Jul 14, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
@Emojigit Emojigit requested a review from appgurueu August 3, 2024 23:29
sfan5
sfan5 reviewed Aug 4, 2024
View reviewed changes
mods/default/functions.lua Outdated Show resolved Hide resolved
mods/default/functions.lua Outdated Show resolved Hide resolved
@Emojigit

This comment was marked as resolved.

Sign in to view
@Emojigit Emojigit marked this pull request as draft August 31, 2024 23:12
@Emojigit Emojigit marked this pull request as ready for review August 31, 2024 23:24
sfan5
sfan5 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mods/default/functions.lua Show resolved Hide resolved
@Emojigit @sfan5
The holy comments
0dab776 
Co-authored-by: sfan5 <sfan5@live.de>
@sfan5 sfan5 merged commit b23c44d into minetest:master Sep 8, 2024
2 checks passed
@j-r j-r mentioned this pull request Sep 11, 2024
Open
MoNTE48 pushed a commit to MoNTE48/minetest_game that referenced this pull request Sep 22, 2024
@Emojigit @MoNTE48
Get rid of recursive call in default.dig_up (minetest#3133)
a6d534f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker Awaiting requested review from SmallJoker

@appgurueu appgurueu Awaiting requested review from appgurueu

Assignees
No one assigned
Labels
One approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack overflow due to default.dig_up
4 participants
@Emojigit @sfan5 @SmallJoker @appgurueu