admin actions and authentication for student#3
Open
minhquanghapo wants to merge 1 commit intoadminfirstfrom
Open
admin actions and authentication for student#3minhquanghapo wants to merge 1 commit intoadminfirstfrom
minhquanghapo wants to merge 1 commit intoadminfirstfrom
Conversation
| } | ||
|
|
||
| public function addTeacher(RequestStudent $request) | ||
| public function addTeacher(RequestTeacher $request) |
There was a problem hiding this comment.
Anh nghĩ là tên file request nên đặt tường minh cho cái hành động đấy Vd như: UpdateTeacher, StoreTeacher..
| return [ | ||
| 'id' =>'required|numeric', | ||
| 'id' =>'required|numeric|unique:students', | ||
| 'name' => 'required|max:50|min:5|max:255', |
There was a problem hiding this comment.
chưa kiểm tra trường hợp tên là số và các ký tự đặc biệt
| <a href="{{url('admin/teacher/list-teacher')}}">Quản lý giáo viên</a> | ||
| <a href="{{url('admin/student/list-student')}}">Quản lý học sinh</a> | ||
| <a href="{{url('admin/subject/list-subject')}}">Quản lý môn học</a> | ||
| <a href="{{url('admin/class/list-class')}}">Quản lý lớp học</a> |
There was a problem hiding this comment.
chuyển thành route hết đi em, dùng url làm gì
| @endif | ||
| <form action="{{url('admin/edit-teacher')}}" method="POST" role="form" enctype="multipart/form-data"> | ||
| <form action="{{url('admin/teacher/edit-teacher/'.$data->id)}}" method="POST" role="form" enctype="multipart/form-data"> | ||
| {{ csrf_field() }} |
There was a problem hiding this comment.
đoạn này k gửi file thì cần gì enctype="multipart/form-data" nhỉ
| <h3>Thông tin học sinh</h3> | ||
|
|
||
| @if (isset(Auth::guard('student')->user()->name) ) | ||
| <p>{!!Auth::guard('student')->user()->name!!}</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
admin actions and authentication for student