feat(MiniExcelDataReaderBase): add asynchronous support #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izanhzh @shps951023 我来测试一下 |
|
@shps951023 BootstrapBlazor 里测试通过，没有问题啦 |
ArgoZhang
approved these changes
Jan 3, 2025
ArgoZhang
approved these changes
Jan 3, 2025
shps951023
reviewed
Jan 4, 2025
| if (columnInfo?.CustomFormatter != null) | ||
| { | ||
| try | ||
| { | ||
| cellValue = columnInfo.CustomFormatter(cellValue); | ||
| } | ||
| catch (Exception e) | ||
| catch |
There was a problem hiding this comment.
TODO: remove try catch by condition
|
🐱🏍 预计下周六发更新版本，我这边在研究 place in cell 图片导出导入功能 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BootstrapBlazor这个库用到了这个基类，GetValue中需要调用一个异步方法，增加异步支持，避免同步方法调用异步方法MiniExcelIssueTests.EmptyDataReaderIssue这个测试用例，对MiniExcel.SaveAsAsync不支持BUG，ExcelOpenXmlSheetWriter.Async对比ExcelOpenXmlSheetWriter漏了一个关键代码逻辑close #707