-
-
Notifications
You must be signed in to change notification settings - Fork 388
Expose IProgress for Exports #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mukunku, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the MiniExcel library by integrating a progress reporting mechanism into its file export capabilities. By exposing an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a great feature to report progress during export operations by exposing an IProgress<int>
parameter. The changes are well-implemented across the different exporters (XLSX and CSV) and public APIs. The new functionality is also covered by unit tests, which is excellent. I've found a couple of issues in the method calls that I've commented on. Once those are addressed, this will be a solid addition to the library.
@mukunku Thank you for your contribution, I'll review it soon! |
Summary
This PR proposes the idea of exposing an
IProgress<int>
parameter in theSaveAsAsync()
extension methods.Reason
I provide file export options in my WinForms utility and for all other supported file types I am able to show a progress bar (since I know the total number of cells to be exported beforehand) but cannot do this with
.xlsx
files currently.Remarks
I really like that this library streams the data as it writes it instead of buffering it in memory so thanks to the creator and supporters.