Skip to content

Comments

LFP-567 - feat: add review management functionality with events, reso…#46

Open
vajdalehel wants to merge 3 commits intofeature/LFP-516from
feature/LFP-567
Open

LFP-567 - feat: add review management functionality with events, reso…#46
vajdalehel wants to merge 3 commits intofeature/LFP-516from
feature/LFP-567

Conversation

@vajdalehel
Copy link

…urces, and policies

Please describe your Pull Request as best as possible, explaining what it provides and why it is of value, referencing any related Issues.

Try to include the following in your Pull Request, where applicable...

  • Documentation updates
  • Automated tests

})
->label(__('lunarpanel::attribute.table.actions.create.label'))
->modalHeading(__('lunarpanel::attribute.table.actions.create.heading'))
->modalHeading(__('lunarpanel::attribute.table.actions.create.heading')),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Szerintem nem jó ötlet ezeket a formázó által generált dolgokat commitolni, mert ez egy PR során menne tovább a fő repóba illetve update során elkezd majd conflicteket okozni.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azt hiszem, hogy a formázások, nem tőlem vannak.
image

image

)
->mutateFormDataUsing(function (array $data) {
$data['type'] = 'condition';
->modalHeading(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ez is csak formázásnak tűnik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants