feat: Global Block & Keep filters

[privatmamtora]

Do you follow the guidelines?

• I have tested my changes
• There is no breaking changes
• I really tested my changes and there is no regression
• [?] Ideally, my commit messages use the same convention as the Go project: https://go.dev/doc/contribute#commit_messages
• I read this document: https://miniflux.app/faq.html#pull-request

Added new feature to enable Global Keep & Block Rules.
Advantages

• Users can keep and maintain a single set of rules that would apply to all feeds.
• Rules are strict to a specific field name specified and doesn't require the user to figure out if there are conflicts.
• Rules can be kept simple if user is having a difficulty managing their rules

Format: FieldName(RegEx)~FieldName(RegEx)~...

FieldName options: Title, URL, CommentsURL, Content, Author, Tags

Addresses: #1326 , #1654 , #1953 , #2583 (maybe)

[fguillot]

Format: FieldName(RegEx)~FieldName(RegEx)~...

FieldName options: Title, URL, CommentsURL, Content, Author, Tags

From a user perspective, I'm wondering if ~ is the right choice for rule separator. Would not be better to have one rule per line in a textarea?

The syntax could be simplified:

EntryURL=(?i)example
Title=(?i)Test

instead of

URL((?i)example)~Title((?i)Test)

I would make the field names explicit to avoid possible confusions: URL -> EntryURL.

[privatmamtora]

Ok will make the following changes:

1. Use a text area, 1 rule per-line
   a. Eliminates the ~ separator
   b. Makes it easier to modify and review rules
2. Use = to separate FieldName and rules
3. I'll change the field names to the following:
   • EntryTitle
   • EntryURL
   • EntryCommentsURL
   • EntryContent
   • EntryAuthor
   • EntryTag

[privatmamtora]

Completed making the changes @fguillot

[fguillot]

I would trim the trailing line feeds and empty lines when fetching the form values. Otherwise, the end-user might get this validation error:

Invalid Block rule: rule #2 is missing a valid field name (Options: 'EntryTitle', 'EntryURL', 'EntryCommentsURL', 'EntryContent', 'EntryAuthor', 'EntryTag')

[privatmamtora]

I would trim the trailing line feeds and empty lines when fetching the form values. Otherwise, the end-user might get this validation error:

Invalid Block rule: rule #2 is missing a valid field name (Options: 'EntryTitle', 'EntryURL', 'EntryCommentsURL', 'EntryContent', 'EntryAuthor', 'EntryTag')

Actually that was the intention, no blank lines allowed. Allows for easily referring to a specific rule# (rule #2 = line number #2)

I guess removing the last line feeds can make it a little more user friendly, excuse any remaining trailing lines

@fguillot Any suggestions on how to remove only blank lines from the end of the textarea string.
If the last line with a rule ends in spaces, that space must be kept as it could be part of the regex rule.

PS: Figured it out with a regex

[privatmamtora]

@fguillot Updated form to sanitize spaces and newlines after a valid keep/block rule

[xfzv]

Shouldn't this comment be updated?

906b2f1#diff-f3574e6be1fa37431084a6f395c2eca7e9b97578b4f91d0ceb6ad32ee0d03b39L218-R218

- rules := strings.Split(filterEntryRules, "~")
+ rules := strings.Split(filterEntryRules, "\n")

[privatmamtora]

Yes, will update.
I also had a dream last night about '\r\n' from windows.
Need to sanitize the string further.
Updating now

[privatmamtora]

Done, sent a new pull request #2726