feat: add alerting API and types #528
Conversation
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
Some clarification needed.
| AlertInternalSubSys = "alert_internal" | ||
| AlertWebhookSubSys = "alert_webhook" | ||
| AlertKafkaSubSys = "alert_kafka" |
There was a problem hiding this comment.
Shouldn't these be included in AlertEvent?
I kinda assume "webhook" can return more than one alert.. or at least subsystems will be able to in the future.
There was a problem hiding this comment.
The AlertInternalSubSys, AlertWebhookSubSys, AlertKafkaSubSys are configuration subsystems
This is required for a feature in EOS to send alerts to configured targets / internally;
There was a problem hiding this comment.
I was thinking in the type Alert struct.
| // GetAlerts retrieves alerts from the MinIO server with the specified options. | ||
| // It returns an iterator that yields AlertEvent objects. | ||
| // Type filtering is case-insensitive and handled server-side. |
There was a problem hiding this comment.
Will "current" events be returned right away? Will events re-fire at regular intervals? What be expected from the API?
There was a problem hiding this comment.
GetAlerts is a streaming API that:
- Makes a POST request to /admin/alerts
- Returns alerts as a stream decoded from JSON
- Uses Interval option to control the check interval on server side
There was a problem hiding this comment.
I was implying it should be documented.
Praveenrajmani
force-pushed
the
alerts
branch
2 times, most recently
from
b06eac6 to
5a93af7
Compare
Add alert types (AlertType, AlertEvent, AlertDetails) and the GetAlerts admin API for retrieving license and certificate expiry alerts.
Praveenrajmani
force-pushed
the
alerts
branch
from
5a93af7 to
7895a80
Compare
2 participants
Add alert types (AlertType, AlertEvent, AlertDetails) and the GetAlerts admin API for retrieving license and certificate expiry alerts.