Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list versions including DEL marker when figuring out Stat() #4951

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jun 5, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

list versions, including DEL marker when figuring out Stat()

Motivation and Context

this is needed to avoid inconsistent behavior when an object
exists v/s DEL marker or FreeVersion exists.

How to test this PR?

You need an object prefix with an object as DEL marker or Free version inside it

Wrong output

mc ls myminio/xxxxxxxxxxxxxxxxxx/task_20240509135930128295846605720846_0008_m_000006 --versions
[2024-06-05 01:43:48 PDT]     0B task_20240509135930128295846605720846_0008_m_000006/

Expected output

mc ls myminio/xxxxxxxxxxxxxxxxxx/task_20240509135930128295846605720846_0008_m_000006 --versions 
[2024-05-09 07:02:58 PDT]     0B LKB f01a25f0-03f6-499c-a99d-3386da7b224a v1 DEL part-00006-d625ba27-82c8-4bcf-85bd-ff351dd09494-c000.snappy.parquet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana force-pushed the list-versions branch 2 times, most recently from 39e6344 to 7f1bca6 Compare June 5, 2024 09:44
cmd/client-s3.go Outdated Show resolved Hide resolved
this is needed to avoid an inconsistent behavior when an
object exists v/s DEL marker or FreeVersion exists.
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 8876275 into minio:master Jun 20, 2024
7 checks passed
@harshavardhana harshavardhana deleted the list-versions branch June 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants