Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror:Add the printing of event time #4953

Merged
merged 25 commits into from
Sep 16, 2024
Merged

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Jun 7, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The event time is printed in watch mode.

Motivation and Context

How to test this PR?

setp1:
keep watch

mc mirror -w test/bucket1 test/bucket2 --quiet

setp2:
upload or remove file.
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze dormanze closed this Jun 7, 2024
@dormanze dormanze reopened this Jun 11, 2024
cmd/mirror-main.go Show resolved Hide resolved
cmd/mirror-main.go Show resolved Hide resolved
@dormanze dormanze requested a review from shtripat June 13, 2024 08:06
@klauspost
Copy link
Contributor

@dormanze Could you address the issues mentioned?

@dormanze
Copy link
Contributor Author

@dormanze Could you address the issues mentioned?

Okay, I've solved it. Please review. Thank you very much.

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello donatello merged commit 37095da into minio:master Sep 16, 2024
5 checks passed
@dormanze dormanze deleted the mirror-event branch October 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants