Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam export:designate zip file name #4995

Merged
merged 27 commits into from
Sep 16, 2024
Merged

iam export:designate zip file name #4995

merged 27 commits into from
Sep 16, 2024

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Jul 24, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Motivation and Context

How to test this PR?

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@klauspost
Copy link
Contributor

It seems a bit contrary to the usual design that the parameter is always assumed to be local path and not an alias.

Adding a -o=/tmp/myminio-iam.zip that allows to override the output path seems more appropriate to me.

@dormanze
Copy link
Contributor Author

It seems a bit contrary to the usual design that the parameter is always assumed to be local path and not an alias.

Adding a -o=/tmp/myminio-iam.zip that allows to override the output path seems more appropriate to me.

This is a good idea. I added a new flag. Please review again.

cmd/admin-cluster-iam-export.go Outdated Show resolved Hide resolved
cmd/admin-cluster-iam-export.go Outdated Show resolved Hide resolved
cmd/admin-cluster-iam-export.go Outdated Show resolved Hide resolved
dormanze and others added 5 commits July 29, 2024 10:03
…port

* 'iamexport' of https://github.com/dormanze/mc:
  trace: avoid aggregate statistics TX/RX with --all (minio#4998)
  Make trace stats more compact (minio#4999)
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
@dormanze dormanze requested a review from klauspost August 5, 2024 11:55
@dormanze
Copy link
Contributor Author

dormanze commented Aug 7, 2024

@harshavardhana Please review my pr again.

@dormanze dormanze requested a review from zveinn August 9, 2024 07:54
@klauspost
Copy link
Contributor

@dormanze I presume it is a script, but could you please turn off the automatic merge with master? It is very noisy and we need to manually re-run tests every time.

@dormanze
Copy link
Contributor Author

@dormanze I presume it is a script, but could you please turn off the automatic merge with master? It is very noisy and we need to manually re-run tests every time.

My bad, This is not a script, I will look at my unclosed pr while browsing the community, manually trigger an update, sorry to bother you, I will stop this operation.

@donatello donatello dismissed harshavardhana’s stale review September 16, 2024 17:31

Requested changes are done

@donatello donatello merged commit 11ebe95 into minio:master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants