heal: Adapt the status based on a new Finished flag #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
approved these changes
Aug 12, 2024
|
update go.mod @vadmeste also fix the title. |
vadmeste
force-pushed
the
avoid-healing-bin-removal
branch
from
a81c242
to
02309f2
Compare
vadmeste
changed the title
|
@harshavardhana PTAL |
klauspost
reviewed
Aug 21, 2024
In a new MinIO version, Healing can be set to false while HealInfo is not nil. This indicates that the drive was healed and the healing is finished. This commit adapts the code with the new concept. This will not break with older MinIO versions since those versions will already remove .healing.bin, in that case Healing will be false, HealInfo will be nil.
vadmeste
force-pushed
the
avoid-healing-bin-removal
branch
from
02309f2
to
3591a90
Compare
harshavardhana
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
In a new MinIO version, Healing can be set to false while HealInfo is not nil.
This indicates that the drive was healed and the healing is finished. This commit
adapts the code with the new concept. This will not break with older MinIO
versions since those versions will already remove .healing.bin, in that case
Healing will be false, HealInfo will be nil.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)