Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch S3 replication config from v2 to v1 #1012

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ASTRobinson
Copy link
Contributor

@ASTRobinson ASTRobinson commented Oct 9, 2024

This PR removes the filter field from the replication configuration which in turn AWS will then identify as a v1 config and replicate deletion markers rather than using v2 configuration where deletion markers have to be specified and set as disabled - further information can be found here https://aws.amazon.com/blogs/storage/managing-delete-marker-replication-in-amazon-s3/

Copy link
Contributor

github-actions bot commented Oct 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.59s
✅ REPOSITORY trivy yes no 15.57s
✅ TERRAFORM terraform-fmt 1 0 0.04s
✅ TERRAFORM tflint yes no 12.49s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ASTRobinson ASTRobinson marked this pull request as ready for review October 9, 2024 09:35
@ASTRobinson ASTRobinson requested a review from a team as a code owner October 9, 2024 09:35
Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks Good To Me!

@connormaglynn connormaglynn merged commit e2a6a7b into main Oct 9, 2024
7 checks passed
@connormaglynn connormaglynn deleted the fixup/S3-replication-v1 branch October 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants