Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IPAM pools for modernisation-platform-core OU #1017

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Oct 16, 2024

This PR is tracked by #8024 in the Modernisation Platform repo.

This PR sets out to create a private IPAM pools for Modernisation Platform live_data and non_live_data VPCs, creating a RAM shares to associate these pools with, and then associating this RAM share with the Modernisation Platform Core OU where it can be accepted.

This will allow accounts in the Modernisation Platform Core OU to accept the relevant RAM share and associate VPCs with the relevant IPAM pool in order to later set up CloudWatch metric alarms based on VpcIPUsage and SubnetIPUsage.

@dms1981 dms1981 requested a review from a team as a code owner October 16, 2024 21:44
Copy link
Contributor

github-actions bot commented Oct 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.67s
✅ REPOSITORY trivy yes no 14.58s
✅ TERRAFORM terraform-fmt 2 0 0.09s
✅ TERRAFORM tflint yes no 11.65s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

…th Modernisation Platform Core OU

tagged Modernisation Platform IPAM pools with an appropriate name tag

re-ran linter
@dms1981 dms1981 force-pushed the feature/create-and-share-ipam-pools branch from 902cb3f to de2e9fb Compare October 16, 2024 21:49
Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 merged commit 7663053 into main Oct 17, 2024
6 checks passed
@dms1981 dms1981 deleted the feature/create-and-share-ipam-pools branch October 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants