Enable config and security hub for eu-west-3 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2024 14:29
Once security hub has been enabled there is no way to amend this value, when trying to import security hub which was already enabled it was set to false. This requried the resource to be destroyed which isn't possible unless you remove the delegation to this account which affects all accounts.
connormaglynn
approved these changes
May 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on the required config settings to enable the default standards in security hub to work.
Security hub for eu-west-3 was already enabled and imported to this TF.
Changes were made to the security hub module introducting an ignore for enable_default_standards, as once security hub has been enabled there is no way to amend this value, when trying to import security hub which was already enabled it was set to false. This required the resource to be destroyed which isn't possible unless you remove the delegation to this account which affects all accounts.
This TF has been applied locally as the pipeline does not have the required permissions.