Remove deleted event handlers from Conductor #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubberlisk
force-pushed
the
remove-deleted-event-handlers-in-conductor
branch
from
11a0e25 to
b7adfc1
Compare
chubberlisk
force-pushed
the
remove-deleted-event-handlers-in-conductor
branch
from
b7adfc1 to
e28eb2a
Compare
|
bjpirt
approved these changes
May 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1450, we removed the event handler JSON for handling new comparison messages and in https://github.com/ministryofjustice/bichard7-next-infrastructure/pull/1681 we removed the comparisonQueue SQS.
However by removing the JSON file, this didn't actually remove it from Conductor. We have a
deploy.tsscript which uses the Conductor API that can create and update workflows, tasks, and event handlers but we've never had to delete ones before.As a result of removing the comparisonQueue the thing that the event handler listening to and not actually removing the event handler properly, Conductor continued to listen and throw an error. This is our current theory for why E2E tests are failing in our deployment pipeline atm.
We expect that we need to update the script to also delete workflows and tasks but for now, we reckon this is the minimum to unblock the deployment pipeline.
https://dsdmoj.atlassian.net/browse/BICAWS7-3472