-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace existing method of obtaining standing data with SDRS API call #292
Draft
Harriet-Hall
wants to merge
29
commits into
main
Choose a base branch
from
standing-data-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-fol
force-pushed
the
standing-data-api
branch
from
August 15, 2024 11:07
5a429d1
to
f1300d0
Compare
joe-fol
changed the title
add missing attributes to zod parsing
Replace existing method of obtaining standing data and replace with A
Aug 20, 2024
joe-fol
changed the title
Replace existing method of obtaining standing data and replace with A
Replace existing method of obtaining standing data and replace with SDRS API call
Aug 20, 2024
joe-fol
force-pushed
the
standing-data-api
branch
3 times, most recently
from
August 21, 2024 08:39
4c77ed6
to
3038d8c
Compare
joe-fol
force-pushed
the
standing-data-api
branch
3 times, most recently
from
September 9, 2024 11:40
6d2651d
to
5979a13
Compare
joe-fol
changed the title
Replace existing method of obtaining standing data and replace with SDRS API call
Replace existing method of obtaining standing data with SDRS API call
Sep 9, 2024
joe-fol
force-pushed
the
standing-data-api
branch
7 times, most recently
from
October 1, 2024 13:08
7dbe144
to
7009abf
Compare
This reverts commit 294936b.
joe-fol
force-pushed
the
standing-data-api
branch
from
October 7, 2024 08:30
7009abf
to
1288c8a
Compare
joe-fol
force-pushed
the
standing-data-api
branch
9 times, most recently
from
November 7, 2024 14:02
48a82f4
to
d0de663
Compare
joe-fol
force-pushed
the
standing-data-api
branch
from
November 7, 2024 14:47
d0de663
to
5589e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old method of creating, updating and maintaining our standing data. Previously we used Puppeteer to interact with a browser to download the data.
This PR allows us to retire the old method and call the SDRS API maintained by CGI, calling the
getOffence
endpoint to get an up to date json object of offence codesstanding-data-api-offences.json
. This file is the equivalent ofpnld-offences.json
which is produced using the old method.We have decided to omit a few keys as they seemed unnecessary/unused
This PR also removes reference to the method of creating the other file
cjs-offences.json
that was processed at the same time when we produces the old input filepnld-offences.json
. We get all the data from the new API call so have removed as redundant.