Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB-3441, VB-3442 Clear notifications - 'do not change' visit after notification #733

Merged
merged 13 commits into from
Apr 16, 2024
Merged

VB-3441, VB-3442 Clear notifications - 'do not change' visit after notification #733

merged 13 commits into from
Apr 16, 2024

Conversation

hutcheonb-moj
Copy link
Contributor

@hutcheonb-moj hutcheonb-moj commented Mar 11, 2024 •
edited by tpmcgowan
Loading

Description

  • Add 'Do not change' button to booking summary page for visits flagged for review
  • New page to clear notifications and give a reason
  • Booking summary timeline shows this event type and reason

@hutcheonb-moj hutcheonb-moj requested a review from tpmcgowan March 11, 2024 09:35
@tpmcgowan tpmcgowan added the do not merge Waiting on additional input, do not merge label Mar 11, 2024
@hutcheonb-moj hutcheonb-moj marked this pull request as ready for review March 12, 2024 11:36
tpmcgowan
tpmcgowan reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@tpmcgowan tpmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍 (not approving as back-end not in place yet)

@hutcheonb-moj hutcheonb-moj changed the title VB-3441, clear notifications initial work VB-3441, Clear notifications - 'do not change' visit after notification Mar 12, 2024
@tpmcgowan tpmcgowan changed the title VB-3441, Clear notifications - 'do not change' visit after notification VB-3441, VB-3442 Clear notifications - 'do not change' visit after notification Apr 11, 2024
@tpmcgowan tpmcgowan removed the do not merge Waiting on additional input, do not merge label Apr 11, 2024
@tpmcgowan tpmcgowan merged commit 3a107e2 into main Apr 16, 2024
9 of 10 checks passed
@tpmcgowan tpmcgowan deleted the VB-3441-clear-notifications-preview branch April 16, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpmcgowan tpmcgowan tpmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hutcheonb-moj @tpmcgowan