Add integration tests for GOV.UK One Login

.circleci/config.yml

@@ -130,9 +130,9 @@ workflows:
       - unit_test:
           requires:
             - build
-      # - integration_test:
-      #     requires:
-      #       - build
+      - integration_test:
+          requires:
+            - build
       - hmpps/helm_lint:
           name: helm_lint
       - hmpps/build_docker:
@@ -144,7 +144,7 @@ workflows:
           requires:
             - helm_lint
             - unit_test
-            # - integration_test
+            - integration_test
             - build_docker
       - hmpps/deploy_env:
           <<: *feature_branch
@@ -182,7 +182,7 @@ workflows:
           requires:
             - helm_lint
             - unit_test
-            # - integration_test
+            - integration_test
             - build_docker
 
       - request-staging-approval:

cypress.config.ts

@@ -1,6 +1,6 @@
 import { defineConfig } from 'cypress'
 import { resetStubs } from './integration_tests/mockApis/wiremock'
-import auth from './integration_tests/mockApis/auth'
+import govukOneLogin from './integration_tests/mockApis/govukOneLogin'
 import tokenVerification from './integration_tests/mockApis/tokenVerification'
 
 export default defineConfig({
@@ -17,7 +17,7 @@ export default defineConfig({
     setupNodeEvents(on) {
       on('task', {
         reset: resetStubs,
-        ...auth,
+        ...govukOneLogin,
         ...tokenVerification,
 
         // Log message to console

feature.env

@@ -1,4 +1,5 @@
 PORT=3007
+INGRESS_URL=http://localhost:3007
 HMPPS_AUTH_URL=http://localhost:9091/auth
 TOKEN_VERIFICATION_API_URL=http://localhost:9091/verification
 TOKEN_VERIFICATION_ENABLED=true

integration_tests/e2e/govukOneLogin.cy.ts

@@ -0,0 +1,54 @@
+import HomePage from '../pages/home'
+import GovukOneLoginPage from '../pages/govukOneLogin'
+import Page from '../pages/page'
+
+context('Sign in with GOV.UK One Login', () => {
+  beforeEach(() => {
+    cy.task('reset')
+    cy.task('stubSignIn')
+  })
+
+  it('Unauthenticated user redirected to GOV.UK One Login - home page', () => {
+    cy.visit('/')
+    Page.verifyOnPage(GovukOneLoginPage)
+  })
+
+  it('Unauthenticated user redirected to GOV.UK One Login - sign-in URL', () => {
+    cy.visit('/auth/sign-in')
+    Page.verifyOnPage(GovukOneLoginPage)
+  })
+
+  it('Unauthenticated user redirected to GOV.UK One Login - callback URL', () => {
+    cy.visit('/auth/callback')
+    Page.verifyOnPage(GovukOneLoginPage)
+  })
+
+  it('Unauthenticated user redirected to GOV.UK One Login - non-existant route', () => {
+    cy.visit('/NON-EXISTANT-PAGE')
+    Page.verifyOnPage(GovukOneLoginPage)
+  })
+
+  it('User can sign in and view home page', () => {
+    cy.signIn()
+    Page.verifyOnPage(HomePage)
+
+    // just testing sample data dumped to the page for now
+    cy.contains('"sub": "user1"')
+    cy.contains('"phone_number": "+440123456789"')
+    cy.contains('"email": "user1@example.com"')
+  })
+
+  it('User sent to auth error page if sign in fails', () => {
+    // setting an invalid nonce value should cause ID token validation to fail
+    cy.signIn({ failOnStatusCode: false, nonce: 'INVALID_NONCE' })
+    cy.get('h1').contains('Authorisation Error')
+  })
+
+  it('User can log out', () => {
+    cy.signIn()
+    const homePage = Page.verifyOnPage(HomePage)
+    homePage.signOut().click()
+    Page.verifyOnPage(GovukOneLoginPage)
+    cy.contains('You have been logged out.')
+  })
+})

integration_tests/e2e/health.cy.ts

@@ -2,7 +2,6 @@ context('Healthcheck', () => {
   context('All healthy', () => {
     beforeEach(() => {
       cy.task('reset')
-      cy.task('stubAuthPing')
       cy.task('stubTokenVerificationPing')
     })
 
@@ -22,11 +21,9 @@ context('Healthcheck', () => {
   context('Some unhealthy', () => {
     it('Reports correctly when token verification down', () => {
       cy.task('reset')
-      cy.task('stubAuthPing')
       cy.task('stubTokenVerificationPing', 500)
 
       cy.request({ url: '/health', method: 'GET', failOnStatusCode: false }).then(response => {
-        expect(response.body.checks.hmppsAuth).to.equal('OK')
         expect(response.body.checks.tokenVerification).to.contain({ status: 500, retries: 2 })
       })
     })

integration_tests/index.d.ts

@@ -2,8 +2,9 @@ declare namespace Cypress {
   interface Chainable {
     /**
      * Custom command to signIn. Set failOnStatusCode to false if you expect and non 200 return code
+     * Optionally set nonce to override the value used in the ID token
      * @example cy.signIn({ failOnStatusCode: boolean })
      */
-    signIn(options?: { failOnStatusCode: boolean }): Chainable<AUTWindow>
+    signIn(options?: { failOnStatusCode: boolean; nonce?: string }): Chainable<AUTWindow>
   }
 }