Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB-2969 Remove unused HMPPS Auth code #23

Merged
merged 4 commits into from
Sep 29, 2023
Merged

VB-2969 Remove unused HMPPS Auth code #23

merged 4 commits into from
Sep 29, 2023

Conversation

tpmcgowan
Copy link
Contributor

@tpmcgowan tpmcgowan commented Sep 28, 2023 •
edited
Loading

  • Remove unused HMPPS Auth code, following implementation of GOV.UK One Login
  • Add Orchestration API to the health check
  • Add an integration test for the API call test page to check that getting tokens for API calls from HMPPS Auth (which is still needed) is mocked and working

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 28, 2023
View reviewed changes
integration_tests/mockApis/hmppsAuth.ts Dismissed Show dismissed Hide dismissed
@tpmcgowan tpmcgowan force-pushed the vb-2969-remove-unused-auth-code branch from 451921d to 8450b18 Compare September 28, 2023 18:36
@tpmcgowan tpmcgowan marked this pull request as ready for review September 28, 2023 18:38
psoleckimoj
psoleckimoj reviewed Sep 28, 2023
View reviewed changes
feature.env Outdated Show resolved Hide resolved
psoleckimoj
psoleckimoj previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

psoleckimoj
psoleckimoj approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tpmcgowan tpmcgowan merged commit ced5557 into main Sep 29, 2023
2 checks passed
@tpmcgowan tpmcgowan deleted the vb-2969-remove-unused-auth-code branch September 29, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psoleckimoj psoleckimoj psoleckimoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpmcgowan @psoleckimoj