VB-3733, VB-3792 User login and booker homepage - tests and code improvements #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tpmcgowan
commented
May 12, 2024
tpmcgowan
commented
- Improve code and error handling for user login and populating the bookerReference
- Add missing unit tests
- Fix integration tests for login and add beginnings (first page) of a booking journey test
tpmcgowan
commented
May 12, 2024
| @@ -1,9 +1,8 @@ | |||
| import IndexPage from '../pages/index' | |||
| import HomePage from '../pages/home' | |||
There was a problem hiding this comment.
Renaming for consistency
tpmcgowan
commented
May 12, 2024
| import { stubFor } from './wiremock' | ||
|
|
||
| const createToken = () => { |
There was a problem hiding this comment.
Removing unnecessary complexity in this stub
tpmcgowan
commented
May 12, 2024
server/data/tokenStore.ts
Outdated
There was a problem hiding this comment.
Unrelated to this PR - removing this stray file and its test (left-overs from a previous TypeScript template update...)
tpmcgowan
commented
May 12, 2024
| @@ -1,4 +1,13 @@ | |||
| {% extends "./partials/layout.njk" %} | |||
| {% from "govuk/components/header/macro.njk" import govukHeader %} | |||
|
|
|||
| {% block header %} | |||
There was a problem hiding this comment.
Authentication error page should use default GOVUK Header; not the One Login header (because you're not logged in to OL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.