VB-3518, additional support page #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpmcgowan
reviewed
May 20, 2024
server/routes/bookingJourney/selectAdditionalSupportController.ts
Outdated
Show resolved
Hide resolved
server/routes/bookingJourney/selectAdditionalSupportController.ts
Outdated
Show resolved
Hide resolved
| @@ -19,6 +19,8 @@ export type BookingJourneyData = { | |||
|
|
|||
| // selected visitors for this visit | |||
| selectedVisitors?: VisitorInfoDto[] | |||
|
|
|||
| visitorSupport?: string | |||
There was a problem hiding this comment.
We've got a bit of a mix in the code of visitorSupport vs additionalSupport: should we standardise on one?
There was a problem hiding this comment.
we send it as visitor support - that's why I chose this naming
tpmcgowan
previously approved these changes
May 20, 2024
tpmcgowan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional support page
Main contact and select date and time have both been blank paged so this page could be made properly