Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubectl v1.29.9 install #66

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix kubectl v1.29.9 install #66

merged 1 commit into from
Sep 18, 2024

Conversation

marcus-bcl
Copy link
Contributor

Currently, attempting to use kubectl in the latest image version throws an error:

<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubernetes-release/release/v1.29.9/bin/linux/amd64/kubectl</Details></Error>

As of 18/09/2024, the Google storage link only has binaries up to v1.28 - see: https://console.cloud.google.com/storage/browser/kubernetes-release/release;tab=objects?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%257B_22k_22_3A_22_22_2C_22t_22_3A10_2C_22v_22_3A_22_5C_22v1.29_5C_22_22%257D%255D%22))&prefix=v1.29&forceOnObjectsSortingFiltering=false

This PR updates the Dockerfile to use the download links from: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.29.md#downloads-for-v1299 and also updates the curl commands to fail if there is an issue downloading the files, to avoid publishing a broken Docker image.

Currently, attempting to use kubectl in the latest image version throws an error:
```xml
<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubernetes-release/release/v1.29.9/bin/linux/amd64/kubectl</Details></Error>
```

As of 18/09/2024, the Google storage link only has binaries up to v1.28 - see: https://console.cloud.google.com/storage/browser/kubernetes-release/release;tab=objects?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%257B_22k_22_3A_22_22_2C_22t_22_3A10_2C_22v_22_3A_22_5C_22v1.29_5C_22_22%257D%255D%22))&prefix=v1.29&forceOnObjectsSortingFiltering=false

This PR updates the Dockerfile to use the download links from: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.29.md#downloads-for-v1299 and also updates the curl commands to fail if there is an issue downloading the files, to avoid publishing a broken Docker image.
Copy link

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petergphillips petergphillips merged commit 8cbd024 into main Sep 18, 2024
10 of 14 checks passed
@petergphillips petergphillips deleted the fix-kubectl-install branch September 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants