Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Slack Service Refactor #4936

Merged
merged 21 commits into from
Oct 28, 2024
Merged

♻️ Slack Service Refactor #4936

merged 21 commits into from
Oct 28, 2024

Conversation

PepperMoJ
Copy link
Contributor

👀 Purpose

To keep our codebase healthy and streamlined, we regularly review and refactor functionality in the operations-engineering repository. This time, is was the slack_service.py.

♻️ What's Changed

  • Removed the send_message_to_plaintext_channel function in favour of consistent usage of existing messaging functions in the Slack Service.
  • Refactored all slack messages that are sent to use this new approach.
  • Added test coverage for add new functions created.

Please see commit history for further and more detailed information.

📝 Notes

Some messages have been modified slightly by removing the 'greeting' and 'goodbye' to make them a little more streamlined, though if we miss this we can certainly add them back (and, as a variable as all messaging code is in the same service).


✅ Things to Check (Optional)

  • I have run all unit tests, and they pass.
  • I have ensured my code follows the project's coding standards.
  • I have checked that all new dependencies are up to date and necessary.

@PepperMoJ PepperMoJ requested a review from a team as a code owner October 22, 2024 15:04
AntonyBishop
AntonyBishop previously approved these changes Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON flake8 17 0 0.68s
✅ PYTHON isort 17 15 0 0.45s
❌ PYTHON pylint 17 7 4.82s
✅ REPOSITORY gitleaks yes no 1.98s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

AntonyBishop
AntonyBishop previously approved these changes Oct 23, 2024
@PepperMoJ PepperMoJ marked this pull request as draft October 23, 2024 14:01
@PepperMoJ PepperMoJ marked this pull request as ready for review October 28, 2024 14:47
@PepperMoJ PepperMoJ merged commit 669efc6 into main Oct 28, 2024
5 of 6 checks passed
@PepperMoJ PepperMoJ deleted the refactor-slack-service branch October 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants