-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Slack Service Refactor #4936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonyBishop
previously approved these changes
Oct 22, 2024
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
AntonyBishop
previously approved these changes
Oct 23, 2024
levgorbunov1
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 Purpose
To keep our codebase healthy and streamlined, we regularly review and refactor functionality in the operations-engineering repository. This time, is was the
slack_service.py
.♻️ What's Changed
send_message_to_plaintext_channel
function in favour of consistent usage of existing messaging functions in the Slack Service.Please see commit history for further and more detailed information.
📝 Notes
Some messages have been modified slightly by removing the 'greeting' and 'goodbye' to make them a little more streamlined, though if we miss this we can certainly add them back (and, as a variable as all messaging code is in the same service).
✅ Things to Check (Optional)